Skip to content

fix(lint): Make ratchet failures actionable - #126784

Merged
natemoo-re merged 4 commits into
masterfrom
fix/actionable-lint-ratchet-errors
Oct 7, 2026
Merged

natemoo-re merged 4 commits into
masterfrom
fix/actionable-lint-ratchet-errors

Conversation

@natemoo-re

@natemoo-re natemoo-re commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Previously, the CI job for lint ratchet failures had a generic error message which made it unclear how to resolve failures.

Stale Baseline

Before

Suppression budgets do not match live debt. Run pnpm run fix:oxlint after cleanup, or pnpm run lint:js --prune for remaining budgets. Use pnpm run lint:js --enroll --base REF for changed policy using trusted source.

After

Suppression budgets are stale. Run pnpm run lint:js --prune and commit the updated oxlint-suppressions.json.

New Violation

Before

New incubator violations:
source.js no-debugger: 2 violations, budget 1

After

New incubator violations:
source.js no-debugger: 2 violations, budget 1
Current violations for over-budget file/rule pairs:
source.js:1:1 no-debugger `debugger` statement is not allowed
source.js:1:11 no-debugger `debugger` statement is not allowed

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 7, 2026
@natemoo-re
natemoo-re marked this pull request as ready for review October 7, 2026 21:06
@natemoo-re
natemoo-re requested review from a team as code owners October 7, 2026 21:06
@natemoo-re
natemoo-re enabled auto-merge (squash) October 7, 2026 21:07
@natemoo-re
natemoo-re requested review from a team and JoshuaKGoldberg October 7, 2026 21:07
@sentry

sentry Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 612 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

auto-merge was automatically disabled October 7, 2026 21:50

Pull Request is not mergeable

@natemoo-re
natemoo-re merged commit 7166f29 into master Oct 7, 2026
73 checks passed
@natemoo-re
natemoo-re deleted the fix/actionable-lint-ratchet-errors branch October 7, 2026 21:56

This branch was successfully deployed

1 active deployment
Preview — aab226c8 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants